Skip to content

fix(slider): not reacting to directionality changes #6744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(slider): not reacting to directionality changes #6744

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

Fixes the slider not updating if its direction is changed dynamically. This is something I came across while testing #6641.

@crisbeto crisbeto requested a review from mmalerba as a code owner August 30, 2017 20:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 30, 2017
@mmalerba
Copy link
Contributor

I believe @g1shin is working on this in her PR for #6542

@crisbeto
Copy link
Member Author

#6542 seems to be related to the focus styles, not the directionality, although the fix should be somewhat similar (adding in a missing markForCheck somewhere).

@crisbeto
fix(slider): not reacting to directionality changes
7476edc 
Fixes the slider not updating if its direction is changed dynamically. This is something I came across while testing angular#6641.
@mmalerba
Copy link
Contributor

mmalerba commented Aug 30, 2017 •
edited
Loading

yeah she's just fixing the various OnPush issues: #6700

@crisbeto
Copy link
Member Author

Alright, closing in that case.

@crisbeto crisbeto closed this Aug 31, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @googlebot